search

crowell / modpagespeed_tmp

Automatically exported from code.google.com/p/modpagespeed
Apache License 2.0
0 stars 0 forks source link

Images inlined for CSS inlines in HTML even when CssImageInlineMaxBytes is zero #650

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. Set CssImageInlineMaxBytes to zero.
2. Leave ImageInlineMaxBytes at the default of 2048.
3. Load a page that has inline CSS with images smaller than 2048 bytes.

What is the expected output? What do you see instead?

    The images should not inline, however, they do.

Please use labels and text to provide additional information.

The prioritize_critical_css needs to have image inlining applied consistently 
between CSS inlined in HTML and external CSS files.

Proposal: In inline CSS, only inline an image if it is smaller than both 
ImageInlineMaxBytes and CssImageInlineMaxBytes.

The planned fix will also update the documentation.

Original issue reported on code.google.com by sl...@google.com on 19 Mar 2013 at 4:22

GoogleCodeExporter commented 9 years ago 
Fixed in r2631.

Original comment by sl...@google.com on 19 Mar 2013 at 9:40