Open GoogleCodeExporter opened 9 years ago
More fundamentally, we should avoid copying this data between configurations if
we can by making it copy-on-write; std::map deep-copies its map.
If we made it a map<SizeInBytes, map<Md5Signature, GoogleString*>> that ought
to suffice, but who owns the GoogleString* is an open question. Perhaps a
SharedString rather than a GoogleString* is the right thing (Josh: would that
work?). That'd share the largest sub-structures. Storing the MD5 hash as a
fixed-size char array is also a possibility, though getting the hashing and
comparison to come out right might involve some slightly-annoying coding.
For that matter, we could use a sorted array and binary search to save space
here if we liked. That might even let us share pointers to all the data about
a given library.
Original comment by jmaes...@google.com
on 30 May 2013 at 7:26
The issue of sharing on Merge is coverged in Issue 712.
This issue is just making the basic thing smaller.
Original comment by jmara...@google.com
on 30 May 2013 at 7:45
Original issue reported on code.google.com by
jmara...@google.com
on 30 May 2013 at 6:58