search

crowell / modpagespeed_tmp

Automatically exported from code.google.com/p/modpagespeed
Apache License 2.0
0 stars 0 forks source link

More sharing in RewriteOptions #715

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The CopyOnWrite pattern -- currently used for DomainLawyer -- should be applied 
to other pointed-to data structures in RewriteOptions.

Original issue reported on code.google.com by jmara...@google.com on 30 May 2013 at 7:02

GoogleCodeExporter commented 9 years ago 
Maks -- can you summarize the current state of the RewriteOptions footprint in 
this issue and track it here?

Original comment by jmara...@google.com on 12 Feb 2014 at 7:56

GoogleCodeExporter commented 9 years ago 
I added it for a few other large objects (WildCardGroups), that made it go 
~6000->5200 (on 64-bit).

There are a few others that are kinda bit, but the bulk comes from basically 
everything taking 24 or 32 bytes. ... Actually, crazily-enough CopyOnWrite<Foo> 
takes one pointer itself, though I would worry it may be a bit too heavy. I am 
thinking I could maybe convince Option<> to be cheaper, or at least to 
sparsen-up the configuration in default case.

Original comment by morlov...@google.com on 12 Feb 2014 at 8:37

GoogleCodeExporter commented 9 years ago 
How much could we buy by putting Option<bool> on a diet somehow?  (Don't know 
how easy this is in C++ though.)

Original comment by jmaes...@google.com on 13 Feb 2014 at 1:52