search

crowell / modpagespeed_tmp

Automatically exported from code.google.com/p/modpagespeed
Apache License 2.0
0 stars 0 forks source link

ModPagespeedRewriteRandomDropPercentage cause duplicate image srcs to be blank. #748

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Input HTML: <img src='a.png'> <img src='a.png'>
Output HTML: <img src='a.png'> <img src=''>

This can occur when RewriteRandomDropPercentage is set to something greater 
than zero and images have duplicate URLs in the same HTML document.  The later 
images have their URLs removed.

Original issue reported on code.google.com by jkar...@google.com on 24 Jul 2013 at 2:38

GoogleCodeExporter commented 9 years ago 
The problem was that RewriteContext::RepeatedSuccess did not pass the kTooBusy 
bit (was_too_busy_) from the primary context to the next in line, so the next 
in line rendered the empty URL.

Original comment by jkar...@google.com on 24 Jul 2013 at 4:47

GoogleCodeExporter commented 9 years ago 
Note that this means that it's also a bug for load shedding.

Original comment by jkar...@google.com on 24 Jul 2013 at 4:47