crowemi / target-s3

singer.io target for S3 built with @meltano SDK
https://hub.meltano.com/loaders/target-s3
9 stars 24 forks source link

config credentials not used yet #3

Closed pnadolny13 closed 1 year ago

pnadolny13 commented 1 year ago

I noticed that I can set credentials in the config but they arent used anywhere yet. Setting them in the environment does seem to work.

crowemi commented 1 year ago

Yes -- this hasn't been configured yet as we're currently pulling these values from the local environment at runtime. I believe we just need to update the session here