Format jsonl not working

crowemi / target-s3

singer.io target for S3 built with @meltano SDK

https://hub.meltano.com/loaders/target-s3

8 stars 19 forks source link

Format jsonl not working #37

Open dror-g opened 2 months ago

dror-g commented 2 months ago

Hi, tried setting the format to jsonl like so:

format:
  format_type: jsonl
  format_parquet:
    validate: false

Got immediate error: 'jsonl' is not a valid choice for 'format.format_type'

Using Meltano Docker image latest

Thanks for all your hard work!!!

dror-g commented 2 months ago

Oh I realise the Meltano hub definitions need updating (weird. why would it break plugins?). Opened a pull request there to add jsonl option and label.

crowemi commented 2 months ago

Hey @dror-g -- I'm not seeing the PR 🤔

dror-g commented 2 months ago

Oh sorry @crowemi , I meant that I opened a PR for Meltano Hub repo to add the Jsonl label & value to hub definitions.

https://github.com/meltano/hub/commit/65aaddb2e886079b157f0224dab70f57bdf8ea65

(This issue can be closed after verifying it works. Thanks again for your work!!!)