crowemi / target-s3

singer.io target for S3 built with @meltano SDK

https://hub.meltano.com/loaders/target-s3

9 stars 24 forks source link

#19: Fix empty filename #38

Open dror-g opened 5 months ago

dror-g commented 5 months ago

19 Fixed using: file_name = stream_name

( :man_shrugging: works for me.. )

ReubenFrankel commented 3 weeks ago

I think you end up with the stream name twice in the file path here, since folder_path already includes the stream name.

https://github.com/crowemi/target-s3/blob/45df1d7749d381d5a71edec265d05b9b001f9773/target_s3/formats/format_base.py#L114-L115 https://github.com/crowemi/target-s3/blob/45df1d7749d381d5a71edec265d05b9b001f9773/target_s3/formats/format_base.py#L128