search

crownheightsaid / mutual-aid-app

Hey we're a mutual aid group in Crown Heights trying to help around town. Please reach out if you want to setup your own slack app and need a hand!
MIT License
24 stars 17 forks source link

Fix balance comparison issues when detecting when reimbursement is complete #102

Open mjmaurer opened 4 years ago

mjmaurer commented 4 years ago

https://crownheightsmutualaid.slack.com/archives/C011D4YBWHL/p1592853085112900?thread_ts=1592853085.112900&cid=C011D4YBWHL

sandfort commented 4 years ago

It looks like we're already using <= for this: https://github.com/crownheightsaid/mutual-aid-app/blob/9385eaa099074ee42de4dc0c7ee5b97157603780/src/slackapp/event-listeners/reimbursementReply.js#L58 Might it be a floating point issue?

mjmaurer commented 4 years ago

Yup! You're probably correct.