Closed martijnvandermarel closed 2 years ago
Hey, thanks for your first pull request (with code)!
Since we want to keep or improve the code quality of the firmware, I'm going to be a bit strict, so sorry for that in advance =]
Overall remarks:
CMD_BLE_SET_MICROAPP_ISR
and CMD_BLE_SET_MICROAPP_CONF
instead of direct function calls?CS_MICROAPP_COMMAND_BLE_SCAN_SET_HANDLER
while it can fail if there are already too many isr registered.CS_MICROAPP_COMMAND_LOG_ARR
implementation should be moved to the log client, right now you need a big buffer on the stack every time, and we try to avoid using sprintf()
. However, I think this should be fixed together with the other microapp functions, so doesn't have to be fixed for this merge.microapp
so they're not confused with other similar named structs.nullptr
instead of 0
or NULL
.
Belongs to https://github.com/crownstone/crownstone-microapp/pull/7
Features:
Please check whether the two new CS_TYPEs that were added are added correctly in cs_Types.cpp and cs_StateData.cpp
For testing the branch, see the crownstone-microapp PR referenced above.