Closed Erno3000 closed 4 years ago
Hey, thanks for the pull request.
One remark:
- lastSphereId: can't this be removed yet? I thought the new lib provides the sphere id?
Hey, thanks for the pull request.
One remark:
- lastSphereId: can't this be removed yet? I thought the new lib provides the sphere id?
Yes, the lib provides sphereId, but not when exiting a region, then it's just null. That's why I renamed 'currentSphereId' to 'lastSphereId' so the usage is a bit clearer. Take a look at line 972 and 987. Maybe the TODO can be omitted.
Hey, thanks for the pull request.
One remark: