Localizationlibupdate - Githubissues

crownstone / crownstone-app

Mobile app for the Crownstone (Android & iOS). The apps are freely available from Google and Apple app stores. The code is based on React Native.

https://crownstone.rocks/app/

Apache License 2.0

16 stars 14 forks source link

Localizationlibupdate #42

Closed Erno3000 closed 4 years ago

vliedel commented 4 years ago

Hey, thanks for the pull request.

One remark:

lastSphereId: can't this be removed yet? I thought the new lib provides the sphere id?

Erno3000 commented 4 years ago

Hey, thanks for the pull request.

One remark:

lastSphereId: can't this be removed yet? I thought the new lib provides the sphere id?

Erno3000 commented 4 years ago

Hey, thanks for the pull request.

One remark:

lastSphereId: can't this be removed yet? I thought the new lib provides the sphere id?

Yes, the lib provides sphereId, but not when exiting a region, then it's just null. That's why I renamed 'currentSphereId' to 'lastSphereId' so the usage is a bit clearer. Take a look at line 972 and 987. Maybe the TODO can be omitted.