search

crownstone / crownstone-lib-python-core

Core of the python library. Contains shared classes, util functions and definitions.
Apache License 2.0
0 stars 2 forks source link

Is BluenetLib still required? #1

Closed hillstub closed 4 years ago

hillstub commented 4 years ago

In file crownstone_core/packets/MicroappPacket.py there's (still) a reference to the BluenetLib:

from BluenetLib.lib.util.fletcher import fletcher32_uint8Arr

Is that intentional? (it's not in the requirements.txt file). Thanks in advance!

AlexDM0 commented 4 years ago

Hi, sorry, that’s sloppiness on my side. I’ll remove it tomorrow! Bluenet is not required anymore.

Thanks for the heads up!

From: hillstub notifications@github.com Sent: Tuesday, August 4, 2020 9:32:18 PM To: crownstone/crownstone-lib-python-core crownstone-lib-python-core@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [crownstone/crownstone-lib-python-core] Is BluenetLib still required? (#1)

In file crownstone_core/packets/MicroappPacket.py there's still a reference to the BluenetLib:

from BluenetLib.lib.util.fletcher import fletcher32_uint8Arr

Is that intentional? (it's not in the requirements.txt file). Thanks in advance!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/crownstone/crownstone-lib-python-core/issues/1, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI5MTKG43PY7AEZ7NOCMM3R7BO4FANCNFSM4PUXIJ7A.

hillstub commented 4 years ago

No worries - I guess we're all human ;-).

Would you be able to match the versions of the dependencies in requirements.txt as well when you're updating the packages? (if that's possible at all).

AlexDM0 commented 4 years ago

I’m not sure what you mean with matching the versions? These libs are different, and the core is used for multiple libraries. The versions will not be identical.

From: hillstub notifications@github.com Sent: Tuesday, August 4, 2020 10:05:04 PM To: crownstone/crownstone-lib-python-core crownstone-lib-python-core@noreply.github.com Cc: Alex alexdemulder@gmail.com; Comment comment@noreply.github.com Subject: Re: [crownstone/crownstone-lib-python-core] Is BluenetLib still required? (#1)

No worries - I guess we're all human ;-).

Would you be able to match the versions of the dependencies in requirements.txt as well when you're updating the packages? (if that's possible at all).

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/crownstone/crownstone-lib-python-core/issues/1#issuecomment-668798405, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI5MTN544IIMEI6B3H7MSTR7BSXBANCNFSM4PUXIJ7A.

hillstub commented 4 years ago

I meant that e.g. in crownstone-lib-python-ble the requirements.txt have (among others) the following dependencies:

crownstone-core==0.5.6

While crownstone-lib-python-uart has

crownstone-core==0.5.7

Would be great if these versions would match so both packages can be used alongside. Sorry, I might have a weird use case: I'm sending the on/off command to a crownstone using the uart package. Unfortunately, that doesn't always come through, so I'd like to double-check the state using the ble package.

AlexDM0 commented 4 years ago

Hi, I've updated the core, and the dependencies for the other libraries. Just this once, they match, but this will not be the case forever. Since we use semver and I don't expect the core to be breaking any time soon, I have set the requirements to >=0.5.8

This should future proof it for a while.

Regards