search

crowsonkb / k-diffusion

Karras et al. (2022) diffusion models for PyTorch
MIT License
2.26k stars 372 forks source link

remove `clean-fid` #38

Closed space-pope closed 1 year ago

space-pope commented 1 year ago

The clean-fid library has an old version of requests pinned in its dependencies that's currently causing me some headaches.

I see a couple discussions related to replacing/reimplementing clean-fid (#7 and #8), and I don't see any imports related to it in the current code, so I was wondering if you'd be open to removing it from the requirements file for the next release. Feel free to close this if not; just thought I'd check.

Thanks!

crowsonkb commented 1 year ago

I'm still using from cleanfid.inception_torchscript import InceptionV3W in evaluation.py and would have to replace it...

space-pope commented 1 year ago

Whoops; I must've searched for usages of clean_fid and the function mentioned above instead of cleanfid...nevermind, then. Thanks for replying.