search

croxis / Lift

Minecraft/Bukkit elevator plugin
23 stars 26 forks source link

Fix minecart NPE issue #145

Closed david50407 closed 7 years ago

david50407 commented 7 years ago

Temporary fix to #143.

This fix will ignore NPE from minecart holder, and give it (0, 0, 0) vector for velocity.

The remain problem is that minecart cannot stack together, if I lift a cart and lift another one, it will stuck together (stuck in lifting mode) until I destroy or move the top cart out of the elevator.

croxis commented 7 years ago

Can you screenshot or video when this happens?

david50407 commented 7 years ago

Video: https://youtu.be/xNlquHOQik0

Before this patch, after I lift first minecart, the NPE exception will keeping output to the console. After this patch, it won't throw any exception and finishes the lifting, but if I lift another cart, it will stuck there until I move/destroy the top one.

BTW, https://youtu.be/I0OflZY2MTo in this viedo, if I break the second cart which is lifting, this elevator will not respond anymore until restart the server