search

croxis / Lift

Minecraft/Bukkit elevator plugin
23 stars 26 forks source link

NCP Incompatibility - Lift causes player fall damage. #151

Closed bc-hill closed 6 years ago

bc-hill commented 6 years ago

As reported on the Spigot resource discussion thread, and confirmed by me, players take damage after riding down elevator. This occurs regardless of speed. Spigot 1.12.2

croxis commented 6 years ago

Is this solo or with multiple passengers

On Tue, Apr 3, 2018, 6:14 AM B notifications@github.com wrote:

As reported on the Spigot resource discussion thread https://www.spigotmc.org/threads/lift.53836/page-3, and confirmed by me, players take damage after riding down elevator. This occurs regardless of speed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/croxis/Lift/issues/151, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHa92r46Wv-EXg-b9mg5gQPaw5BSvAmks5tk3WdgaJpZM4TFDUA .

bc-hill commented 6 years ago

This is solo. I have not yet tested with multiple passengers. Thank you.

bc-hill commented 6 years ago

Confirming that it occurs with two passengers. Though, I am unable to accurately predict who will take damage. Sometimes one player will survive, sometimes both players take damage.

croxis commented 6 years ago

I still can't duplicate it, can you send me a list of plugins?

bc-hill commented 6 years ago

OK, looking at my plugin list again, and thinking about how the fall damage seemed oddly delayed, made me realize the issue. This is a conflict with NoCheatPlus.

If you see here, NCP is trying to enforce fall damage in survival.

I have confirmed that disabling this check resolves the Lift issue.

Would there be a way of making the two play nicely, without having to turn off this protection?

croxis commented 6 years ago

In theory the integration is already there. I'll need to update my copy of ncp and make things work

On Sun, Apr 8, 2018, 9:16 AM B notifications@github.com wrote:

OK, looking at my plugin list again, and thinking about how the fall damage seemed oddly delayed, made me realize the issue. This is a conflict with NoCheatPlus https://www.spigotmc.org/resources/nocheatplus.26/.

If you see here https://github.com/NoCheatPlus/Docs/wiki/%5BMoving%5D-Nofall, NCP is trying to enforce fall damage in survival.

I have confirmed that disabling this check resolves the Lift issue.

Would there be a way of making the two play nicely, without having to turn off this protection?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/croxis/Lift/issues/151#issuecomment-379562210, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHa91uidSOWGwYzEp_RdNLpMrLxR7lUks5tmjfhgaJpZM4TFDUA .

bc-hill commented 6 years ago

I realized that I am using one of the popular newer configs, this one.
Unsure if that is making any difference.

Edit: NoCheatPlus | 3.16.1-SNAPSHOT-sMD5NET-b1143 CompatNoCheatPlus | 6.6.5-RC-sMD5NET-b90

bc-hill commented 6 years ago

I tried the above version of NoCheatPlus with it's default config, and couldn't even ride the elevator.

18-04-10 09:03:24 [INFO] username failed SurvivalFly: tried to move: -233.97, 90.06, 152.95 -> -233.97, 89.56, 152.95, d=0.50 (data_reset+vdistrel). VL 105.
18-04-10 09:03:24 [INFO] username failed SurvivalFly: tried to move: -233.97, 90.06, 152.95 -> -233.97, 88.99, 152.95, d=1.07 (data_reset+vdistrel). VL 462.
18-04-10 09:03:27 [INFO] username failed SurvivalFly: tried to move: -233.97, 90.06, 152.95 -> -233.97, 89.56, 152.95, d=0.50 (data_reset+vdistrel). VL 1519.
18-04-10 09:03:27 [INFO] (CONSOLE) Kicked username: Kicked for flying (or related)

Edit: This was already reported in #148

croxis commented 6 years ago

Should be fixed