search

croxis / Lift

Minecraft/Bukkit elevator plugin
23 stars 26 forks source link

Compile error accessing private property of LiftSign #157

Closed LeoQuote closed 5 years ago

LeoQuote commented 5 years ago

at https://github.com/croxis/Lift/blob/master/src/main/java/net/croxis/plugins/lift/SpongeLiftRedstoneListener.java#L98 accessing private property of LiftSign

I changed the property to public and works fine https://github.com/croxis/Lift/blob/master/src/main/java/net/croxis/plugins/lift/LiftSign.java#L45

But I wonder if there's any side effect.... did you experienced this?

croxis commented 5 years ago

I had it set to public, but now that I'm trying to update the sign syntax in a somewhat safe way behind the LiftSign class I switched it to private. I forgot to push my recent changes which should fix the problem. Redo the pull request if I didn't. I hope to get a new version out soon.

LeoQuote commented 5 years ago

sure thing, thanks for your contribution, looking forward to the next version!