search

croxis / Lift

Minecraft/Bukkit elevator plugin
23 stars 26 forks source link

81 percent TPS loss , with last commit #189

Closed Tsoccerguy3 closed 4 years ago

Tsoccerguy3 commented 4 years ago

There is a big bug in this with 1.16.3 paper build 195. /timings report shows a tps loss of 81 percent and the lift plugin dlows the sever down to a crawl. mem leak or wrong API ? IDK

kikelkik commented 4 years ago

I fixed these issues with my Pull-Request which is not in the master yet. If you want that fix now, you can download a self-compiled version from here: https://minecraft-corp.de/downloads/Lift-67.jar

Tsoccerguy3 commented 4 years ago

I saw this , I pulled your fixes to my local GIT and it works. Thanks

kikelkik commented 4 years ago

Cool, so you can close this ticket @Tsoccerguy3

croxis commented 4 years ago

Hijacking -- kikelkik, do you want to take over maintaining the plugin? I haven't played minecraft seriously in years.

kikelkik commented 4 years ago

Sorry, I felt responsible for this because my changes have been the reason :D (Or wasn't your answer ironic?)

Tsoccerguy3 commented 4 years ago

croxis , If you are fixing the bug I will close this issue as fixed

Tsoccerguy3 commented 4 years ago

fixed in pull request from kikelkik . closing

croxis commented 4 years ago

kikelik, I was serious

kikelkik commented 4 years ago

@croxis You can add me as contributor here on github, spigot and bukkit, so I could help you out without having to create pull requests ^^

croxis commented 4 years ago

@kikelkik can you pm me your spigot and bukkit profile names?

kikelkik commented 4 years ago

I texted you there. github does'nt support pms