search

croxton / Stash

Stash allows you to stash text and snippets of code for reuse throughout your templates.
GNU General Public License v3.0
197 stars 20 forks source link

Stash Set/Append and Whitespace #61

Open leigeber opened 11 years ago

leigeber commented 11 years ago

I am trying to build out a query for the query module and despite having a trailing/leading whitespacing when setting or appending it gets stripped. I thought trim was set to no by default but even specifically setting it doesn't seem to help. Any thoughts? Thanks.

leigeber commented 11 years ago

Scratch this, I'm pretty sure this was blatant user error. Sorry for the false alarm.

leigeber commented 11 years ago

Actually I was just able to replicate this...

{exp:stash:set name="test"} test {/exp:stash:set} {exp:stash:append name="test" trim="no"} 123 {/exp:stash:append} {exp:stash:get name="test"}

If you have a line break on both the gap between test and 123 closes. If you close up either the set or the append it opens back up. Strange..

croxton commented 11 years ago

Stash doesn't do any trimming unless you specifically ask it to. EE trims whitespace in params automatically, but I didn't think it did that for tagdata enclosed by a tag pair, unless that's changed.

Are you testing this on windows or mac? EE 2.7?

leigeber commented 11 years ago

EE 2.7 w/ Windows. Thanks.

croxton commented 11 years ago

It's a windows line-break thing for sure, but Stash isn't doing anything other than concatenating the strings it gets passed when it appends/prepends. It could be EE's template class that's causing this behaviour. I have a windows box somewhere so I'm going to do some tests and see if I can work out where this is happening.

croxton commented 10 years ago

Wasn't able to reproduce this on my windows box. Leaving open in case anyone can shed light.