croz-ltd / tiller

🔖 Tiller DS is an open-source UI library that provides a range of visual, functional components and patterns that speed up design and development.
https://croz-ltd.github.io/tiller
Apache License 2.0
28 stars 1 forks source link

DataTable sorting always present #239

Closed fbeceic closed 7 months ago

fbeceic commented 8 months ago

Basic information

Bug description

DataTable's sorting arrows next to column names are always shown, even if the specified column has the canSort prop set to false.

Cursor pointer is not shown (regular cursor is on hover), but the sorting functionality is still present.

Additionally, sorting on the selector column (if <DataTable.Selector /> is defined) is present, which makes no sense since this column shouldn't be sortable.

Steps to reproduce

Expected behavior

Columns with canSort set to false shouldn't have sorting functionality when clicking on the column header. Selector columns shouldn't be sortable.

Actual behavior

Columns with canSort set to false have sorting functionality when clicking on the column header. Selector columns are always sortable.