search

crp2a / BayLum

Chronological Bayesian models integrated for Optically Stimulated Luminescence (OSL) Dating
https://crp2a.github.io/BayLum/
GNU General Public License v3.0
9 stars 1 forks source link

New feature/runajgs #22

Closed baumbuddy closed 2 years ago

baumbuddy commented 2 years ago

First update:

RLumSK commented 2 years ago

@nfrerebeau I don't understand why the Appveyor CI is still triggered. I had removed that but there is still something in the repository settings I cannot access. Would you mind double-checking?

RLumSK commented 2 years ago

@IMHarly A BIG thanks for this huge amount of work! I've made a few comments, however, I guess we have to merge it and see how it works and then correct more. There are simply too many changes. If possible, please commit only files you really changed, this means everything in man/ does not usually need to be committed except for the files you have changed otherwise it becomes a little bit. What is the summary.pdf for? Was it a mistake in the commit?

P.S.: I have changed the GitHub CI, so of you change something all the tests should start now.

baumbuddy commented 2 years ago

Yes, you are right. I should commit only the files I actually work with. I did see that there were changes in alot of other files, which I thought must have resulted from roxygen::roxygenise. I didn't think too much about it, and thought to myself "Oh well - must be necessary then!".

"Summary.pdf" is a mistake. It is from an array of tests I ran. I must have switched R-project (and working-directory with it) and then run additional tests.

About appveyor. I am not sure what is happening or how to correct it. I will take a look at it.

baumbuddy commented 2 years ago

@RLumSK

I don't see any webhooks or anything else that points to AppVeyor CI within the fork settings. So I guess that at the time of the fork, the AppVeyor ties were cut.

RLumSK commented 2 years ago

I don't see any webhooks or anything else that points to AppVeyor CI within the fork settings. So I guess that at the time of the fork, the AppVeyor ties were cut.

@IMHarly You are right, but there must be something in the setting itself, only @nfrerebeau can check that, I don't have access to those settings in the organisation.

RLumSK commented 2 years ago

Yes, you are right. I should commit only the files I actually work with. I did see that there were changes in alot of other files, which I thought must have resulted from roxygen::roxygenise. I didn't think too much about it, and thought to myself "Oh well - must be necessary then!".

That's alright, but the automated manual building runs over all files, and then you usually only commit the one with changes related to your changes in the R files. Not a big deal, though.