search

crs-tools / tracker

CRS Ticket Tracker
Apache License 2.0
18 stars 11 forks source link

Slugification of capital umlauts can be improved #174

Closed a-tze closed 6 years ago

a-tze commented 6 years ago

For example, in the filename template a capital Ü is transliterated to UE, which means that e.g. Überwacher is transliterated to UEberwacher.

Ideas: either take some explicit care of it, or slugify to a complete lower-case string.

jjeising commented 6 years ago

Conversion for Umlauts is currently done here. I think manual replacement was done, because intl transliterates ü to u instead of ue. Currently we don't check the context (Überwacher should transliterate to Ueberwacher, but TÜV should transliterate to TUEV), but this seems a little more complex. A regular expression would probably help.

jjeising commented 6 years ago

Fixed here and in 460d6d3.