search

crs-tools / tracker

CRS Ticket Tracker
Apache License 2.0
18 stars 11 forks source link

Initital meta ticket state, fixes #141 #214

Closed a-tze closed 5 years ago

a-tze commented 5 years ago

SQL: allow empty ticket state on insert into tbl_ticket, fill with calculated initial state

Import: create tickets with NULL ticket_state

jjeising commented 5 years ago

Looks good to me.

The other usages of the intial state are here:

https://github.com/crs-tools/tracker/blob/d247e4e1c5479dc8ed166ab9e47d696cddac9ff6/src/Application/Controller/XMLRPC/Handler.php#L299-L303

https://github.com/crs-tools/tracker/blob/d247e4e1c5479dc8ed166ab9e47d696cddac9ff6/src/Application/Controller/XMLRPC/Handler.php#L406

Maybe you would want to change these, too?

As far as I understand we could also set ticket_state to null here:

https://github.com/crs-tools/tracker/blob/d247e4e1c5479dc8ed166ab9e47d696cddac9ff6/src/Application/Model/Ticket.php#L837-L841

(It resets the encoding tickets.)

Ticket creation via the UI uses the form values that were pre filled from a query of available states, so these should be fine.