crs4 / hl7apy

Python library to parse, create and handle HL7 v2 messages.

http://crs4.github.io/hl7apy/

MIT License

224 stars 88 forks source link

Rename MSA_1 field to ACKNOWLEDGMENT_CODE for versions < 2.5 #47

Closed RuggeroDAlo closed 5 years ago

RuggeroDAlo commented 5 years ago

I think the field name was misspelled

coveralls commented 5 years ago

Coverage remained the same at 95.262% when pulling ea07d96457dd7785cd6764a447033539ba05342e on RuggeroDAlo:develop into 91be488e9274f6ec975519a1d9c17045bc91bf74 on crs4:develop.

coveralls commented 5 years ago

Coverage decreased (-0.4%) to 94.873% when pulling 490debead2f17a60dc64c28bd7cf334f09f97371 on RuggeroDAlo:develop into 91be488e9274f6ec975519a1d9c17045bc91bf74 on crs4:develop.

svituz commented 5 years ago

Hi @RuggeroDAlo, I think it's the other way round: the correct spelling is acknowledgement and the error is in version >= 2.5

RuggeroDAlo commented 5 years ago

I've double checked all the hl7 documentation and from what I can see the only version that uses acknowledgement is the 2.2. From 2.3 on the field is spelled acknowledgment.

2.2:

2.3.1:

231

2.4:

2.5:

2.6:

2.7.1:

2.8.2:

svituz commented 5 years ago

Ok, thanks. I'll accept the PR and fix the name for 2.3.1 and 2.4 myself