Drop official support for Python 3.4

crs4 / hl7apy

Python library to parse, create and handle HL7 v2 messages.

http://crs4.github.io/hl7apy/

MIT License

231 stars 91 forks source link

Drop official support for Python 3.4 #64

Closed sloria closed 4 years ago

sloria commented 4 years ago

Python 3.4 is 6 years old at this point

coveralls commented 4 years ago

Coverage increased (+0.2%) to 95.273% when pulling d82cb8fc715bdacf062baf4ab84506eb9e804a0f on sloria:drop-py34 into beba03d289ca05d332d9011997f660dbe9afa3f3 on crs4:develop.

svituz commented 4 years ago

Hi @sloria. You're right that Python 3.4 is "growing old", but I can't see the point of removing the support, considering that it doesn't affect anyhow Python constructs used in the module. That's why I'm not merging your PR. Thanks anyway

Vittorio

sloria commented 4 years ago

Yeah, this doesn't affect current code usage. This would moreso to reduce the maintenance burden going forward, i.e. you wouldn't need to deal with users' py34-specific issues. Faster CI builds are also an ancillary benefit.

No problem with not merging this now. It's worth noting, though, that 3.5 has quite a few nice features esp. w/r/t typing that are backwards-incompatible with 3.4. So when 2.7 support is dropped, perhaps it would also be worth