search

crs4 / hl7apy

Python library to parse, create and handle HL7 v2 messages.
http://crs4.github.io/hl7apy/
MIT License
215 stars 85 forks source link

ORU_R01 missing obx fields #78

Closed ryoung29 closed 3 years ago

ryoung29 commented 4 years ago

First of all, thank you for all the hard work on this library. It is by far my favorite HL7 library for Python.

According to this specification, obx should have up to 25 fields, but the implementation only has 22.

I will be sending a pull request to add the 3 extra fields.

asulis commented 4 years ago

Dear RYoung,

first of all thank you, we are pleased to know that you appreciate our work. Thank you also for your good catch: the library effectively misses OBX 23, 24 and 25 fields support for the OBX segment in the 2.5.1 version. However, concerning your PR, notice that HL7 does not have an official 2.5.2 release, so as the library must be kept aligned with official HL7 releases, what we have to do to fix this issue is to do that in the 2.5.1 version. The only thing you should do here is to fix 2.5.1's segments.py and fields.py. Could you abort your PR and insert a new one for that ?

Best regards, Alessandro

ryoung29 commented 4 years ago

Sure thing. I almost asked if I should take that approach before I submitted a PR. I'll update it.

svituz commented 3 years ago

closed in #919d81b36d0fdf53d69fd7e842c70094e34fde47