search

crs4 / hl7apy

Python library to parse, create and handle HL7 v2 messages.
http://crs4.github.io/hl7apy/
MIT License
215 stars 85 forks source link

ORU_R01 v2.5.1 missing OBX fields (Issue #78) #86

Closed jmagid15 closed 3 years ago

jmagid15 commented 3 years ago

Building off ryoung29's PR to add missing OBX fields to v2.5.1 parser and addressing the syntax issues in their original pull request.

Issue #78

svituz commented 3 years ago

Hi @jmagid15, thanks for the PR. You are right about the OBX-23,24,25 that were in the wrong place and HL7 2.5.1 leaves 20,21,22 blank. That said we cannot merge your PR in this way, because your definition of OBX-20,21,22 is specific for your use case and doesn't apply to the generic standard. We would merge it if you delete the 20,21,22 definitions leaving them blank (as, for example, in the case of MSA-5). For your use case, hl7apy provides support to message profiles. You can read the documentation here