crs4 / notredam

Automatically exported from code.google.com/p/notredam
http://www.notredam.org
17 stars 4 forks source link

Wrong extension type in redition filenames when downloading an item #84

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Select an original pdf or png item
2. Download the item
3. Select either zip or tar.gz

What is the expected output? What do you see instead?
Inside the zip or tarball the renditions thumbnail, preview and fullscreen have 
the same extension as the original but in reality they are JPEG files.
I expected to see '.jpg' extensions instead for renditions other than the 
original.

What version of the product are you using? On what operating system?
changeset:   2055:9988fa26629d
branch:      notredam-replacement

os: ubuntu 12.04.2 server amd64

Please provide any additional information below.
I suspect this must happens for many other kind of files (extensions) as well.
For now only tested with original pdf and png.

Original issue reported on code.google.com by goo...@gmail.com on 9 Apr 2013 at 5:06

GoogleCodeExporter commented 9 years ago
Another example:

Uploaded a Matroska video file.
The thumbnail was generated correctly.
Downloaded the item tarball with the folowing files:
 - xxx_original.mkv: a matroska file as the original.
 - xxx_preview.mkv: a Macromedia Flash media file (not a matroska container). Should it have a '.flv' extension?
 - xxx_thumbnail.mkv: a JPEG file. Sould it have a '.jpg' extension instead of '.mkv'?

Original comment by goo...@gmail.com on 10 Apr 2013 at 8:30

GoogleCodeExporter commented 9 years ago
I must say that inside the directory /var/spool/notredam almost all files have 
the correct extensions but with hashes names.

All of then but one, the original matroska file with the extension .mkv was 
named 2aca1401dce740769c0e886069ffaaad_1_original.mpv note the incorrect mpv 
extension (MPEG video?)

Original comment by goo...@gmail.com on 10 Apr 2013 at 8:42

GoogleCodeExporter commented 9 years ago
Those wrong extensions also happens when downloading a rendition file 
individually clicking on the diskette icon inside the summary panel. 

Original comment by goo...@gmail.com on 10 Apr 2013 at 9:56

GoogleCodeExporter commented 9 years ago
Names of files in links in the right summary panel are the same as those on the 
file system path /var/spool/notredam/ (in the standard installation).

All nearly perfect.
The exception as said before is the matroska original file that gets the wrong 
'.mpv' extension.

Original comment by goo...@gmail.com on 10 Apr 2013 at 10:18

GoogleCodeExporter commented 9 years ago
There was a bug. You could update your clone.

Original comment by fabrizio.solinas83@gmail.com on 10 Apr 2013 at 12:58

GoogleCodeExporter commented 9 years ago
This solves the names files inside the zip or tarball when you right click an 
item to download it.

However, inside the right summary/preview panel the link to download each 
rendition still gets the extensions wrong.

Do you prefer that I open a new issue for this?

Original comment by goo...@gmail.com on 10 Apr 2013 at 2:58

GoogleCodeExporter commented 9 years ago
No, it's ok. Definitely it is fixed!

Original comment by fabrizio.solinas83@gmail.com on 11 Apr 2013 at 6:55