crs4 / notredam

Automatically exported from code.google.com/p/notredam
http://www.notredam.org
17 stars 4 forks source link

`SmartFolders: "myquery"` doesn't work because of space before quotes #92

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. create a smart folder search named "cats" (without quotes) or whatever, 
which should find some actual results.
2. when you click the smart folder name, it loads into the Quick Search area 
the following:
SmartFolders: "cats"
3. That query returns no results because of the space before the quotes. If you 
remove the space, the query works.

What is the expected output? What do you see instead?

I would expect it to either load `SmartFolders:"cats"` without quotes into the 
Quick Search area, or ignore whitespace on the server-side that isn't inside 
the quotes.

What version of the product are you using? On what operating system?

 current version of notredam-replacement

Please provide any additional information below.

Attached is a hg diff to ignore whitespace for the SmartFolder query on the 
server-side, which fixes the problem. I don't know if you'd rather not load it 
with whitespace into the Quick Search in the first place though. I did a quick 
grep for "SmartFolders" to try to determine which Javascript file was loading 
that, but I couldn't find it, so I patched on the server-side temporarily.

Original issue reported on code.google.com by sapient....@gmail.com on 15 May 2013 at 12:19

GoogleCodeExporter commented 9 years ago
I found where the QuickSearch is loaded via Javascript, and am attaching 
another hg diff for a patch that loads the SmartFolder query into the HTML 
input without the space before the quotes.

Original comment by sapient....@gmail.com on 15 May 2013 at 12:29

Attachments:

GoogleCodeExporter commented 9 years ago
Hi,

tks a lot. fixed :).

brixio.

Original comment by fabrizio.solinas83@gmail.com on 15 May 2013 at 7:39