search

crschnick / pdx_unlimiter

A smart savegame manager, editor, and toolbox for all current major Paradox Grand Strategy games.
https://discord.gg/BVE4vxqFpU
GNU General Public License v3.0
250 stars 23 forks source link

Release configuration #104

Open aalmiray opened 1 year ago

aalmiray commented 1 year ago

At first glance I would have expected the following configuration to throw an exception

https://github.com/crschnick/pdx_unlimiter/blob/e52fb88ae0a18af6868724387145b617d993b1bb/gradle/jreleaser.gradle#L74-L79

The distributionType property is owned by the distribution (named app) and not by the artifact DSL element.

crschnick commented 1 year ago

I guess it works fine because no task depends the distribution type property as I only use the GitHub release. The jreleaser configuration here is very old and bad as I had no idea what I was doing back when I first created it. It should probably be updated sometime.

aalmiray commented 1 year ago

OK. Moreover, I suppose releases are done offline. Here's a way to run releases on GitHub targeting multiple platforms

https://github.com/kordamp/ikonli/blob/master/jreleaser.yml https://github.com/kordamp/ikonli/blob/master/.github/workflows/release.yml

The project is a JavaFX application that also relies on beryx's plugins to build the jlink runtimes and native installers via jpackage.

crschnick commented 1 year ago

They are done on CI by running each OS separately and updating the body of the release. I already use your linked workflow approach in xpipe, it's just that I didn't also implement it here. This is mostly because the current approach also works even though it's a little bit ugly. I will probably do a complete rewrite of the jreleaser configuration someday.