crsdc / badgerapp

Badger Watch: recognise, record and report badger persecution in England and Wales. An app developed with Flutter for Android and iOS.
https://crsdc.github.io/badger/
2 stars 0 forks source link

Emails generated under iOS 14 have <BR>s inserted #16

Open crsdc opened 2 years ago

crsdc commented 2 years ago

Due to a known bug with iOS (see details), emails generated by the app under iOS 14.6 and at least some subsequent 14.x contain inappropriately placed HTML \<BR> tags whenever the string we pass has a newline character, which our reports need plenty of for readability.

Opening an issue to keep track if this becomes a big problem. Marking as wontfix for now since it appears to be difficult for developers to mitigate. Fault lies with Apple, who have fixed their own bug in iOS 15. Solution for users is to upgrade to iOS 15, or use a different mail app on their iPhone to the one affected (the stock iOS mail client?). For users who are unable to upgrade, we will have odd-looking emails, but all the data should be there. The problem will be if users are confused by what they are seeing and don't send reports.

Please comment if you see this behaviour. If you see other problems with how our app's email report is rendered in your email app please file a separate bug report.

crsdc commented 2 years ago

This may be more of a problem than I'd hoped. According to one source, although its accuracy is unclear, about 71% of iPhones are running the affected versions of iOS (14.6, 14.7, 14.8) as of September 2021. That share will decline over time, and the new iOS 15 released this summer is apparently available for iPhones up to about six years old, but we'll still be stuck with plenty of iPhones running the affected versions by the time of public release. As a large chunk of those will likely be using the stock email app that's a lot of users who'll see a report that looks like this:

Incident details based on questions and answers:<BR><BR>This is a sett interference incident linked to forestry or tree surgery.<BR><BR>The interference was ongoing at the time I began trying to report it.<BR><BR>This sett interference is believed to be unlicensed, or I'm unable to confirm whether there's a licence.<BR><BR>Work interfering with the sett was NOT stopped when asked.<BR><BR>Incident date not provided.<BR><BR>Not reported to police, or not yet at time of this report.<BR><BR>OS grid ref: AA 12345 54321 [default for testing]<BR>Nearest town: any town<BR>County: Devon [default for testing]<BR><BR>Evidence held:<BR>Photo/video of the aftermath of sett interference<BR>Photo/video of a dead or injured badger<BR>Photo/video of the sett taken before sett interference<BR>Sketch map<BR><BR>First name: John<BR>Last name: Smith<BR>Contact email: johnsmith@example.org<BR>Phone: 123456789<BR><BR>[Report begun 2021-10-20 21:51 with Project Badger v1.2.13, last modified 22:17]

Instead of like this:

Incident details based on questions and answers:

This is a sett interference incident linked to forestry or tree surgery.

The interference was ongoing at the time I began trying to report it.

This sett interference is believed to be unlicensed, or I'm unable to confirm whether there's a licence.

Work interfering with the sett was NOT stopped when asked.

Incident date not provided.

Not reported to police, or not yet at time of this report.

OS grid ref: AA 12345 54321 [default for testing] Nearest town: any town County: Devon [default for testing]

Evidence held: Photo/video of the aftermath of sett interference Photo/video of a dead or injured badger Photo/video of the sett taken before sett interference Sketch map

First name: John Last name: Smith Contact email: johnsmith@example.org Phone: 123456789

[Report begun 2021-10-20 21:51 with Project Badger v1.2.13, last modified 22:17]

CF will also be faced with these blocks of text when looking at incident reports.

The email only looks a mess once it's been passed to the email app. The preview screen in our app will look fine, so the user will have some idea what they're sending, but may find it quite jarring when they see their report looking mangled in this way, and it may put them off hitting send.

Reclassifying this from wontfix to bug, since it is looking more likely it will have to be mitigated somehow, though the options for doing that are not necessarily going to be straightforward.

crsdc commented 2 years ago

Whether this is still much of a problem will become clear with release to a wider pool of users. There is a workaround but would prefer not to implement it unless really necessary as it will trade very ugly emails on one version of iOS for slightly ugly emails on all versions. So removing from open beta milestone pending more info on how widespread it is.

crsdc commented 1 year ago

It appears all Apple devices that ran iOS 14 are able to run at least iOS 15, so there are now not likely to be as many affected users as we'd feared.