crserran / home-alarm

Alexa & Google Home alarm integrations and notifications system for your home security.
https://crserran.github.io/home-alarm
MIT License
22 stars 6 forks source link

feat(media_player): add default init volume #18

Closed xaviml closed 1 year ago

xaviml commented 1 year ago

This PR adds a new optional attribute for the Media Player alert - default_init_volume.

When the alarm is triggered, Home Alarm collects the current volume level of all media player to then restore initial volume once alarm is stopped (btw, love this feature!). However, some media players do not support volume_level when they are turned off, so the attribute cannot be retrieved and it is marked as None. Then, when it tries to restore it, the code fails since it cannot change volume to None.

This PR adds a default init volume option for such cases. So, if the retrieved volume from the media player is None, then it will be assigned the default_init_volume value. If the media players contain the volume_level before turning on, then, nothing will change for those.