crsh / citr

RStudio Addin to Insert Markdown Citations
Other
407 stars 46 forks source link

requires RStudio 0.99.796 or newer (your version is 1.3.1093) #84

Open slager opened 3 years ago

slager commented 3 years ago
> citr:::insert_citation()
Error in citr:::insert_citation() : 
  The use of this addin requires RStudio 0.99.796 or newer (your version is 1.3.1093).
> sessionInfo()
R version 4.0.3 (2020-10-10)
Platform: x86_64-apple-darwin17.0 (64-bit)
Running under: macOS Mojave 10.14.6

Matrix products: default
BLAS:   /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/4.0/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] citr_0.3.2

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.6        digest_0.6.27     later_1.1.0.1    
 [4] assertthat_0.2.1  mime_0.9          R6_2.5.0         
 [7] lifecycle_0.2.0   xtable_1.8-4      magrittr_2.0.1   
[10] rlang_0.4.10      rstudioapi_0.13   miniUI_0.1.1.1   
[13] promises_1.1.1    ellipsis_0.3.1    tools_4.0.3      
[16] shiny_1.6.0       fastmap_1.1.0     httpuv_1.5.5     
[19] compiler_4.0.3    htmltools_0.5.1.1
ulyngs commented 2 years ago

Same problem here: "The use of this addin requires RStudio 0.99.796 or newer (your version is 2021.9.0.351)."

FM-uib commented 2 years ago

I think the problem is in this part of insert_citation.R line 52 to 63.

  context <- NULL
  if(rstudioapi::hasFun("getSourceEditorContext")) {
    context <- tryCatch(rstudioapi::getSourceEditorContext(), error = function(e) NULL)
  }
  else if(rstudioapi::hasFun("getActiveDocumentContext")) {
    context <- rstudioapi::getActiveDocumentContext()
  }
  if (is.null(context)) stop(
    "The use of this addin requires RStudio 0.99.796 or newer (your version is "
    , rstudioapi::versionInfo()$version
    , ")."
  )

rstudioapi::getSourceEditorContext() returns NULL in RStudio 2022.07.1+554, while rstudioapi::getActiveDocumentContext() returns a result. getSource was added in 0.99.1111 and getActive was added later in 0.99.796. I think switching the if checks may solve this issue.

  context <- NULL
  if(rstudioapi::hasFun("getActiveDocumentContext")) {
    context <- rstudioapi::getActiveDocumentContext()
  }  
  else if(rstudioapi::hasFun("getSourceEditorContext")) {
    context <- tryCatch(rstudioapi::getSourceEditorContext(), error = function(e) NULL)
  }

  if (is.null(context)) stop(
    "The use of this addin requires RStudio 0.99.796 or newer (your version is "
    , rstudioapi::versionInfo()$version
    , ")."
  )
kubakrukar commented 2 years ago

This modification allowed me to load the package but it then freezes when connecting to a running Zotero. When I click on "Zotero connection available. Connect and load libraries" I get:

Warning: Error in curl::curl_fetch_memory: Operation was aborted by an application callback
  108: <Anonymous>
  107: stop
  106: bibliography
   99: renderText
   98: func
   85: renderFunc
   84: output$read_error
    3: shiny::runApp
    2: runGadget
    1: citr:::insert_citation
> sessionInfo()
R version 4.2.0 (2022-04-22)
Platform: x86_64-apple-darwin17.0 (64-bit)
Running under: macOS Monterey 12.3.1

Matrix products: default
LAPACK: /Library/Frameworks/R.framework/Versions/4.2/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
[1] compiler_4.2.0 tools_4.2.0   

Correction The connection with Zotero works fine as long as the Zotero window is not closed (red X button on MacOS). So I'm keeping it open full-screen underneath other windows.

joaoventuraoliveira commented 2 years ago

It´s not works for me! Do you have another ideas for solution this error?