`predictionInterval()` vectorization

crsuzh / ReplicationSuccess

R package for Design and Analysis of Replication Studies

https://crsuzh.github.io/ReplicationSuccess/

1 stars 0 forks source link

`predictionInterval()` vectorization #21

Closed florafauna closed 3 years ago

florafauna commented 3 years ago

Vectorize() is not really compatible with a data.frame output.

Maybe the function could return a matrix?

SamCH93 commented 3 years ago

I agree with this change

CharlotteMicheloud commented 3 years ago

I agree with this change

Me too

florafauna commented 3 years ago

I found that changing the output to a matrix format would not simplify the implementation much. (Vectorize() somehow loses the column names of the matrix). As it is working as it is, I consider this a low priority issue and close it. Feel free to change the implementation and make a pull request.