search

crtahlin / medplot

Functions for drawing graphs in R visualizing medical information.
4 stars 2 forks source link

Regression models #110

Open llaarraa opened 10 years ago

llaarraa commented 10 years ago

Add the P values (going through the tabs with regression now, P values missing for linear regression at least)

llaarraa commented 10 years ago

looks quite good, RCS for logistic regression is missing?

crtahlin commented 10 years ago

Actually, I haven't implemented RCS for logistic scenario (binary outcome), since I thought it was only applicable for the numeric outcome scenario ( that's how I interpreted #90 ). I'll try to add it, but I would like to give it a lower prioritiy, since it could be a relatively time consuming issue (the menu showing/hiding scenarios are very "sensitive" to changes). Also, if we want to implement it "properly", I guess we would have to add another menu, to choose either Firth correction, RCS modelling or none of the above? Since otherwise, the user could check both the Firth correction checkbox and the RCS modelling checkbox. Or maybe we just hide one of them, when the other is selected ... Will think about it.

llaarraa commented 10 years ago

would implement it, if possible, (would not bother for Firth's, just for the regular logistic regression). you should have the code necessary for the implementation also for glm (I should have sent you the code at some point also for glm)