search

crtahlin / medplot

Functions for drawing graphs in R visualizing medical information.
4 stars 2 forks source link

Graph Timeline #42

Open llaarraa opened 10 years ago

llaarraa commented 10 years ago

The upper part of the graph is cut off (intensity of the symtoms appears only for large values - problem that appears when selecting all the symptoms, too many, the legend is alligned with the lower margin of the graph; the upper part is cut off )

llaarraa commented 10 years ago

When the number of day from inclusion is selected, the x-axis labels might be horizontally aligned

llaarraa commented 10 years ago

Add also the possibility to have x-axis by measurement occasion

llaarraa commented 10 years ago

Would it still work if we had continuous numerical variables? Tried it with 0-10 values so far, is it general enough to support any kind of variables??

crtahlin commented 10 years ago

Implemented requested feature in 09340669601647d95d55519223160ed177ce2ab8.

At the moment, the size of the plotted points is explicitly set to be between 0 and 10 by the ggplot function:

scale_size_area(breaks=c(1:10),minor_breaks=c(1:10),
                guide="legend",
                limits=c(1,10),
                max_size=10)

Values larger than 10 seem to be regarded as missing and are not plotted. Non-integer values between 0 and 1 seem to get plotted normally. Negative values are also regarded as missing and do not get plotted.

I don't recall exactly how the ggplot scale_size_area() works - it might be possible to enable dynamically generating the legend and scaling appropriately even for values outside the range of 0 to 10. But what kind of values would we allow? Too large a range of positive values would not work (a range of 1 to 10 is still barely visible, a range of 1 to 100 would probably not be). Also, how to display negative values? I think it would not make sense to allow just any kind of numeric values for this particular graph.

crtahlin commented 10 years ago

Idea: for a numerical variable outside of [1:10] range, do a cut of the variable into decils. Then the decils are shown on Timeline. (It could be problematic, if the distri. is not symetric.)

crtahlin commented 10 years ago

Three different types of "x-axis" are implemented. Values outside 1-10 are not supported, as at the moment no sensible option exists. Bumping down priority.