search

crubier / react-graph-vis

A react component to render nice graphs using vis.js
http://crubier.github.io/react-graph-vis/
MIT License
953 stars 171 forks source link

Problems with graphs in Router based applications #38

Open turnipsoft opened 6 years ago

turnipsoft commented 6 years ago

Thanks for a great component, however there's a clash when using this along with React Router, when you're using HashRouter, since this component renders a # in the end of the URL where the component is used, confusing the routing system.

Do you know any way to get rid of this # in the URL and why is it need at all, besides rendering graph components by params in the url

crubier commented 6 years ago

Hi, this seems to be caused by vis.js as this component does not directly do that. I would happily take a PR about this. This might only be a matter of passing the right options to vis

turnipsoft commented 6 years ago

I thought it was likely visjs that did this. Gonna look into it, and do a PR if I solve it :-)

ghost commented 4 years ago

was this issue ever fixed because i am getting an error when i try to host my application on heroku. the error states: Uncaught (in promise) TypeError: Cannot read property 'v4' of undefined