search

crucialfelix / django-ajax-selects

jQuery UI-powered auto-complete fields for ForeignKey, ManyToMany and text fields
Other
822 stars 249 forks source link

Popup not closing Django 3.1.1 #274

Closed breduin closed 3 years ago

breduin commented 3 years ago

Using Django 3.1.1 In fact, the problem is the same as in https://github.com/crucialfelix/django-ajax-selects/issues/176 , so that I've just copied the text.

Installed ajax-selects and everything works fine except that when I click +add in admin foreign key fields (or M2M key fields) I get the popup window, fill it, click save and it doesn't disappear, staying blank with popup closing... in the head it can be closed manually and finally it creates the foreign object, but doesn't link it to the one i was editing

Those time the problem was solved by downgrading to Django 1.9, but today it's definitely not the best idea ))

crucialfelix commented 3 years ago

Fixed in https://github.com/crucialfelix/django-ajax-selects/commit/73de2febb883bdd3312ff85180b30a62f8a662b2

breduin commented 3 years ago

Thank you very much for fast commit! Works fine.

crucialfelix commented 3 years ago

Sure thing! I must admit there aren't good tests for the frontend against all Django versions. It could use cypress e2e tests

On Mon, 5 Oct 2020, 08:29 breduin, notifications@github.com wrote:

Thank you very much for fast commit! Works fine.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/crucialfelix/django-ajax-selects/issues/274#issuecomment-703426711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABVM4VLERFHAIOYVCFTZWTSJFRVJANCNFSM4R7C7G6Q .