search

crucialfelix / django-ajax-selects

jQuery UI-powered auto-complete fields for ForeignKey, ManyToMany and text fields
Other
822 stars 249 forks source link

Setup Github Actions #290

Closed andyzickler closed 2 years ago

andyzickler commented 2 years ago

Closes #278 Please review and merge #289 first as this builds on that.

I created a simple GitHub action to run tox in python 3.8, 3.9 and 3.10. It currently only runs the flake8 command in python 3.8 because the other versions were causing an error that I don't understand yet. I think it might be possible to also run flake8 as a separate GitHub action. I'll look into it.

Let me know what you think and if you have any suggestions / changes. This is my first time working with GitHub actions, but so far it seems pretty easy.

This uses the tox-gh-actions plugin to help with the multiple python versions.

andyzickler commented 2 years ago

You can see the action run on a test PR I made on my own fork https://github.com/andyzickler/django-ajax-selects/actions/runs/1670368955

Here's the run with the failed flake8 command https://github.com/andyzickler/django-ajax-selects/runs/4746163178?check_suite_focus=true

crucialfelix commented 2 years ago

I merged #289 and then rebased this, making a new PR #292 and merged that.

Doing a release right now. Thanks so much and sorry for the delay!

andyzickler commented 2 years ago

Great! I'm so happy this works