search

crucialwebstudio / chargify-sdk-php

Chargify SDK for PHP
Apache License 2.0
26 stars 44 forks source link

new Request in V2 is not including base_url, causes all requests to fail #10

Closed brynnb closed 8 years ago

brynnb commented 8 years ago

https://github.com/chargely/chargify-sdk-php/blob/master/src/Crucial/Service/ChargifyV2.php#L198

This causes a "error" => "Could not resolve host: calls" because it is attempting to make a request to "url" => "HTTP://calls/01200a96bbe01fbc5177abd3396e2caae9d4d0f2". I assume there is something about the version of Guzzle you updated to that does not read the base_url as expected when you create a new httpClient

brynnb commented 8 years ago

Found the issue, base_url needs to be changed to base_uri as per this upgrade guide:

The base_url option has been renamed to base_uri.

Looks like it was already fixed in the V1 service, just forgotten in V2 one.

dan-bowen commented 8 years ago

Thanks for the bug report. This has been fixed in 0.1.1