search

crucialwebstudio / chargify-sdk-php

Chargify SDK for PHP
Apache License 2.0
26 stars 44 forks source link

Create products-family #12

Closed asoseil closed 7 years ago

dan-bowen commented 7 years ago

Thank you for your interest in the project and for submitting the PR. I have made some comments that would need to be addressed in order for this to be accepted.

Also, please add unit tests around this new functionality. Please refer to https://github.com/chargely/chargify-sdk-php/tree/master/tests/phpunit for existing tests.

dan-bowen commented 7 years ago

Also, this will need to target the develop branch, not master.