Closed teodortalov closed 7 years ago
Hello. Thank you for your interest in this project. I have made a few comments that would need to be addressed in order for this to be accepted. Also, could you add some tests around this new functionality? Please refer to existing test here. https://github.com/chargely/chargify-sdk-php/tree/master/tests/phpunit
Also, this PR will need to target the develop
branch, not master
. Thanks.
@crucialwebstudio , thanks for your feedback. I will implement the changes you recommended and add some tests and update the PR to develop.
Thanks :)