CRToastInteractionTypeSwipeUp doesn't dismiss the notification

cruffenach / CRToast

A modern iOS toast view that can fit your notification needs

MIT License

4.17k stars 463 forks source link

CRToastInteractionTypeSwipeUp doesn't dismiss the notification #194

Open mm11715 opened 8 years ago

mm11715 commented 8 years ago

CRToastInteractionTypeSwipe and CRToastInteractionTypeSwipeUp are broken.

When displaying a notification with an interaction responder of type CRToastInteractionTypeSwipeUp or CRToastInteractionTypeSwipe, the swipeGestureRecognizerSwiped: is not called for a swipe up. The UIGestureRecognizerDelegate gestureRecognizer:shouldReceiveTouch: method is called, however.

Using version 0.0.9, tested on both iOS 8.4 and 9.2.1

jordanhbuiltbyhq commented 8 years ago

I can confirm this is an issue. SwipeDown works, SwipeUp does not.

Donnit commented 8 years ago

+1 I found that SwipeUp works only if swipe up gesture starts from the bottom border of the notification banner. If you start swiping up a little bit above the bottom border the gesture is not recognized and, more dangerous, if you also have a tap interaction type, it will be recognized as tap.