search

cruffenach / CRToast

A modern iOS toast view that can fit your notification needs
MIT License
4.17k stars 463 forks source link

CRToast should build without warnings #218

Closed iosdev-republicofapps closed 7 years ago

iosdev-republicofapps commented 7 years ago

Hi,

Awesome pod, thanks for releasing this! :-)

We like to have clean builds without warnings but cannot because CRToast generates build warnings in Xcode Version 8.2.1 (8C1002):

/Users/joel/src/GetLive/Pods/CRToast/CRToast/CRToastManager.h:45:9: Parameter 'options' not found in the function declaration

/Users/joel/src/GetLive/Pods/CRToast/CRToast/CRToastManager.h:68:9: Parameter 'identifier' not found in the function declaration

I think these are just code doc issues. I could generate a PR to fix if you'd be willing to review and issue a release? :-)

Thanks!

Ashton-W commented 7 years ago

A PR would be welcome

iosdev-republicofapps commented 7 years ago

Will do, thanks!

Sent from my iPhone

On Feb 16, 2017, at 4:00 AM, Ashton Williams notifications@github.com wrote:

A PR would be welcome

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.