search

cruise-automation / daytona

A Vault client, but for containers and servers.
Apache License 2.0
310 stars 33 forks source link

Log renew errors & tag images with git tag #20

Closed dplummer closed 5 years ago

dplummer commented 5 years ago

Two changes, I can split them if you'd like.

  1. I see the container as a sidecar restarting, and while I think it's because of Vault timeout, I'd like to see the error.
  2. Tags the docker images using the latest docker tag. Appends the latest commit sha if not on a tag. So this branch is: 
    $ make image                                
docker build -t daytona:1.0.1-11-gfbb7f80  .

    Future releases you can run git tag -s v1.0.2 to tag and then the image tag will be up-to-date.

dustin-decker commented 5 years ago

Looks good, thanks!