search

cruise-automation / daytona

A Vault client, but for containers and servers.
Apache License 2.0
301 stars 33 forks source link

Simplify auth method #74

Closed nbutton23 closed 3 years ago

nbutton23 commented 3 years ago

Right now each auth method has its own flag: --k8s-auth, --aws-auth, etc.

This doesn't scale and we should migrate to an input method: --auth-method that takes an input for which type of auth to do (k8s/aws/gcp/azure, etc.)

Also move {gcp,k8s,aws}-auth-mount to auth-mount and move the existing auth-mount to auth-path, Where auth-mountis used to generate a auth-path if not provided. The defaults for auth-mount and auth-path are handled during the validation of the auth-method

This is a breaking change of the API.

broamski commented 3 years ago

Looking good. We should do the same for {gcp,k8s,aws}-auth-mount and simplify it to auth-mount

nbutton23 commented 3 years ago

Yeah I was thinking about that. . . it gets a little complicated on how we handle the different defaults (unless you know a simple way to do that). I can play around with a few options.