cruise-automation / daytona

A Vault client, but for containers and servers.
Apache License 2.0
301 stars 33 forks source link

Add a longer retry wait to Vault client #96

Closed robertfairhead closed 1 year ago

robertfairhead commented 1 year ago

The Vault API does not allow overriding the default max retry wait value via Environment variable. The default of 1500 milliseconds is sufficient if rate-limiting on 1 second buckets.

If using minute-length rate limiting buckets, we could need a longer value. This allows the Vault client to wait for a bit longer than a minute if the server instructs it to do so via the Retry-After header. It allows for overriding our new default via an environment variable if so desired.

robertfairhead commented 1 year ago

Ok, further testing and tweaks to our middleware and I don't think this will be necessary for Daytona to work correctly in the presence of rate limiting. Going to close this out and can reopen if necessary later.