search

cruise-automation / rbacsync

Automatically sync groups into Kubernetes RBAC
Apache License 2.0
238 stars 33 forks source link

Fix rbac.yaml #25

Closed davidxia closed 4 years ago

davidxia commented 4 years ago

The "escalate" permission needs to be added to (Cluster)Role not (Cluster)RoleBinding. Users might also need the "bind" permission.

See https://v1-13.docs.kubernetes.io/docs/reference/access-authn-authz/rbac/#privilege-escalation-prevention-and-bootstrapping

davidxia commented 4 years ago

I'm not sure why I'm getting this error. I've signed the commit. Does my public key need to be uploaded somewhere or am I missing something else?

$ GIT_CHECK_EXCLUDE="./vendor" git-validation -q -run DCO,short-subject,dangling-whitespace
 f4e3cb9 - FAIL - does not have a valid DCO
davidxia commented 4 years ago

ah I have to add the signed off by line

stevvooe commented 4 years ago

@davidxia thanks for the clarification here.

I fixed a small type with a commit but I can't push the signature to your branch. Can you squash in my fix and re-push with the Signoff? Sorry about the back and forth.

davidxia commented 4 years ago

Done, thanks!