cruise-automation / rbacsync

Automatically sync groups into Kubernetes RBAC
Apache License 2.0
238 stars 33 forks source link

metrics: add gauges for fulfilled configurations #8

Closed stevvooe closed 4 years ago

stevvooe commented 5 years ago

Need a better way of ascertaining whether RBACSync is healthy. Export metrics for number of fulfilled rbacsyncconfigs vs errored. This will allow detection of upstream issues with monitoring.

stevvooe commented 5 years ago

May want to pair this work with https://github.com/cruise-automation/rbacsync/issues/6#issuecomment-455012962 to add status reporting.

mattlandis commented 5 years ago

Discussed in further detail with @stevvooe offline. Documenting more details here for when this gets picked up.

Metrics in the Controller:

Metrics in Mapper/GSuite

mllu commented 4 years ago

this issue was addressed in https://github.com/cruise-automation/rbacsync/pull/19 and released in https://github.com/cruise-automation/rbacsync/releases/tag/v1.2.0, we should be good to close this issue. Thanks for helping review.