cruise-automation / webviz

web-based visualization libraries
https://webviz.io/
Apache License 2.0
2.08k stars 412 forks source link

[feature request] change panel background color #376

Open agarret7 opened 4 years ago

agarret7 commented 4 years ago

Would it be possible to add functionality for changing the background color of the 3D visualization panels? In particular it would be nice to be able to select a white background.

janpaul123 commented 4 years ago

Sounds like a good idea to me! cc @vidaaudrey @davidswinegar

vidaaudrey commented 4 years ago

Yeah good idea. We could add as part of the 3D panel menu options here, perhaps with a color picker to choose the background. @agarret7 let us know if you are interested in taking it. Otherwise I could pick it up early next week if time permits.

agarret7 commented 4 years ago

I'm receiving a bunch of compile when running npm run bootstrap, mostly looking something like:

/home/austin/.node-gyp/12.16.1/include/node/v8config.h:328:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../../nan/nan_new.h:189:0,
                 from ../../nan/nan.h:222,
                 from ../src/binding.cpp:1:
../../nan/nan_implementation_12_inl.h: In static member function ‘static Nan::imp::FactoryBase<v8::Function>::return_t Nan::imp::Factory<v8::Function>::New(Nan::FunctionCallback, v8::Local<v8::Value>)’:
../../nan/nan_implementation_12_inl.h:105:32: error: no matching function for call to ‘v8::Function::New(v8::Isolate*&, void (&)(const v8::FunctionCallbackInfo<v8::Value>&), v8::Local<v8::Object>&)’
                           , obj));
agarret7 commented 4 years ago

I accidentally closed the issue.

vidaaudrey commented 4 years ago

Could you maybe try node v10.15.3 (the version I have at my Mac)?

agarret7 commented 4 years ago

That worked. Perhaps worth opening another issue on compatibility with nodejs: '>10.19.0'?

vidaaudrey commented 4 years ago

Yeah totally.