"Error: SharedArrayBuffer is not defined" while trying to play back images

cruise-automation / webviz

web-based visualization libraries

https://webviz.io/

Apache License 2.0

2.04k stars 412 forks source link

"Error: SharedArrayBuffer is not defined" while trying to play back images #662

Open KevS272 opened 3 years ago

KevS272 commented 3 years ago

Hello,

when I try to play back the compressed image topic of my rosbag I just get the error message

Error: SharedArrayBuffer is not defined

It also says "failed to decode image on /detection_image/compressed:" Screenshot from 2021-07-25 19-08-17

I am using Chrome version 92.0.4515.107 (Official Build) (64-bit).

I was looking on the web for the problem and it seems that google did some stuff with the SharedArrayBuffer, but I'm not familiar with the whole topic: https://developer.chrome.com/blog/enabling-shared-array-buffer/

Any idea how this could be fixed?

Thanks and BR Kevin

l33tl4bs commented 3 years ago

@KevS272 I fixed the issue making the following changes:

packages/webviz-core/src/util/binaryObjects/binaryTranslation/index.js:178 replaced const BufferType = self.crossOriginIsolated ? SharedArrayBuffer : ArrayBuffer; with const BufferType = ArrayBuffer;
packages/webviz-core/src/panels/ImageView/renderImage.js:121 replaced const notSharedData = rawData.buffer instanceof SharedArrayBuffer ? new Uint8Array(rawData) : rawData; with const notSharedData = rawData;
packages/webviz-core/.eslintrc.js:61 replaced SharedArrayBuffer: true, with SharedArrayBuffer: false,

unclear if all three changes are needed
unclear what the implications of changes are
maybe someone more knowledgeable can comment on this

geetesh commented 3 years ago

Hello,

when I try to play back the compressed image topic of my rosbag I just get the error message

Error: SharedArrayBuffer is not defined

It also says "failed to decode image on /detection_image/compressed:"

I am using Chrome version 92.0.4515.107 (Official Build) (64-bit).

I was looking on the web for the problem and it seems that google did some stuff with the SharedArrayBuffer, but I'm not familiar with the whole topic: https://developer.chrome.com/blog/enabling-shared-array-buffer/

Any idea how this could be fixed?

Thanks and BR Kevin

Upvoting. I am using the web-version and facing the same issue https://webviz.io/app/

chenjunnn commented 3 years ago

~~I also have the same problem. The image can be correctly encode, but compressedImg can't be.~~ When I tried the newest version of Webviz, I found this problem has been fixed. 👍 807d59337c083bad95d2305b47b390a

jtbandes commented 3 years ago

For anyone experiencing this issue, I'd encourage you to try out Foxglove Studio, which renders compressed and uncompressed images without using SharedArrayBuffers.

Foxglove Studio is a visualization tool originally based on webviz, available as a cross-platform native app and also a web app. If you have any questions or issues with it, you can contact us on GitHub or in our Slack workspace!