search

cruise-automation / webviz

web-based visualization libraries
https://webviz.io/
Apache License 2.0
2.01k stars 408 forks source link

Add dataTest to button props for testing #726

Closed eseakin closed 2 years ago

eseakin commented 2 years ago

Summary

There seems to be no easy way to select buttons for clicking in tests. Added data-test tag to <button> so that it can be tested. Note: The prop is dataTest, but becomes data-test on the button to match existing patterns.

Test plan

Tested manually to verify that the tag comes through.

Versioning impact

This shouldn't affect versions.

eseakin commented 2 years ago

Closing as duplicate to https://github.com/cruise-automation/webviz/pull/728